Personal tools
You are here: Home Members chrism software buildit_issues SkelCopier is broken
Issue 10 of buildit_issues [BUILDIT]
Title: SkelCopier is broken
Status: Rejected Security related: No
Description: There are two problems with SkelCopier in v1.0 - it does not correctly handle nested directories - it does not remove the '.in' suffix from template ...
From: Kent on: Jul 31, 07 21:57
Anonymous User Last update: Jul 31, 07 22:13
Topic/class: Zope/bug Importance: medium
Version info: 1.0
Issue 10 Transcript
2 entries
= Reject - Entry #2 by chrism on Jul 31, 2007 10:13 pm

 Status: Pending => Rejected

Thanks. I believe both of these issues were already fixed in the patch attached to http://agendaless.com/Members/chrism/software/buildit_issues/6 which has been checked in to CVS and will make it out in the next release.
________________________________________
= Request - Entry #1 by Anonymous User on Jul 31, 2007 9:57 pm

There are two problems with SkelCopier in v1.0

- it does not correctly handle nested directories
- it does not remove the '.in' suffix from template file names

Here is a patch:

@@ -324,12 +324,14 @@
 
             for filename in filenames:
                 # Copy the file:
- src = os.path.join(skeldir, filename)
- dst = os.path.join(tgtdir, filename)
+ src = os.path.join(dirpath, filename)
+ relpath = dirpath[len(skeldir):]
+ dst = os.path.join(tgtdir, relpath, filename)
                 if os.path.exists(dst):
                     continue
                 sn, ext = os.path.splitext(filename)
                 if os.path.normcase(ext) == ".in":
+ dst = dst[:-3]
                     infilecopier = InFileWriter(src, dst)
                     infilecopier.execute(task)
                 else:

Powered by Plone CMS, the Open Source Content Management System

This site conforms to the following standards: